wayland: Don't continue showing if xdg_popup creation failed
authorJonas Ådahl <jadahl@gmail.com>
Sat, 18 Apr 2020 20:51:21 +0000 (22:51 +0200)
committerJonas Ådahl <jadahl@gmail.com>
Sat, 18 Apr 2020 20:57:25 +0000 (22:57 +0200)
commitab59459f7a93149fb05b6c1660317a8eddd2a526
tree8a7500456b4199f7be5e0ddb74f5c99882ee7371
parent0a79eb02acc1041704b26a0b1483cb8e4574c22b
wayland: Don't continue showing if xdg_popup creation failed

We don't create a grabbing popup if it's not the top most one, as that
is a protocol violation, and complain if anything attempts to do it.
What we didn't do is handle this gracefully in the code that tries to
create said popup.

Fix this by dropping the attempt to show the popup on the floor, instead
of setting various state making it look like it succeeded. This won't
actually fix anything, but it'll result in a bit more accurate warnings
logged, as the state more correctly corresponds to the reality.
gdk/wayland/gdksurface-wayland.c